martin/emacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify 'comint-write-input-ring'

Browse Source 
* lisp/comint.el (comint-write-input-ring): Use
'with-temp-buffer', 'decf' and write the buffer contents without
'buffer-string'.  (bug#79954)
This commit is contained in:
Philip Kaludercic
2025-12-06 12:22:03 +01:00
parent b969905a47
commit a465c43b29
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lisp/comint.el
View File

@@ -1120,21 +1120,16 @@ See also `comint-read-input-ring'."
((not (file-writable-p comint-input-ring-file-name))
(message "Cannot write history file %s" comint-input-ring-file-name))
(t
(let* ((history-buf (get-buffer-create " *Temp Input History*"))
(ring comint-input-ring)
(let* ((ring comint-input-ring)
(file comint-input-ring-file-name)
(separator comint-input-ring-separator)
(index (ring-length ring)))
;; Write it all out into a buffer first. Much faster, but messier,
;; than writing it one line at a time.
(with-current-buffer history-buf
(erase-buffer)
(with-temp-buffer
(while (> index 0)
(setq index (1- index))
(insert (ring-ref ring index) separator))
(write-region (buffer-string) nil file nil 'no-message)
(kill-buffer nil))))))
(insert (ring-ref ring (decf index)) separator))
(write-region nil nil file nil 'no-message))))))
(defvar comint-dynamic-list-input-ring-window-conf)