martin/emacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix spurious warnings from unwise condition order in inlined code

Browse Source 
These are both conditions having the form (and A B) where A is
side-effect-free and B may be known to be nil at compile time.
The compiler will then warn about A being useless and thrown away.
The fix is to test B first.

* lisp/gnus/gnus.el (gnus-method-to-server):
Test `(not no-enter-cache)` first.
(gnus-server-get-method): Test `group` first.
This commit is contained in:
Mattias Engdegård
2021-02-04 14:32:21 +01:00
parent 83983b6b7a
commit 4dc3231c91
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lisp/gnus/gnus.el
View File

@@ -3212,8 +3212,8 @@ that that variable is buffer-local to the summary buffers."
(format "%s" (car method))
(format "%s:%s" (car method) (cadr method))))
(name-method (cons name method)))
(when (and (not (member name-method gnus-server-method-cache))
(not no-enter-cache)
(when (and (not no-enter-cache)
(not (member name-method gnus-server-method-cache))
(not (assoc (car name-method) gnus-server-method-cache)))
(push name-method gnus-server-method-cache))
name)))
@@ -3273,8 +3273,7 @@ that that variable is buffer-local to the summary buffers."
(gnus-server-to-method method))
((equal method gnus-select-method)
gnus-select-method)
((and (stringp (car method))
group)
((and group (stringp (car method)))
(gnus-server-extend-method group method))
((and method
(not group)