From 560c84b62b346e1ce6edc0a334cdbfaa37de7884 Mon Sep 17 00:00:00 2001 From: Tobias Bading Date: Mon, 25 Feb 2019 14:26:38 +0100 Subject: [PATCH 1/3] Fix last change on 'compilation-parse-errors' * lisp/progmodes/compile.el (compilation-parse-errors): Fix previous change in this function. (Bug#34479) Copyright-paperwork-exempt: yes --- lisp/progmodes/compile.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 5312a55a258..49b79de5851 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1432,7 +1432,7 @@ to `compilation-error-regexp-alist' if RULES is nil." (let ((this-type (if (consp type) (compilation-type type) (or type 2)))) - (compilation--note-type type) + (compilation--note-type this-type) (compilation--put-prop file 'font-lock-face From f3dab022324504309cca331b324cb6fed8b5a67c Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Fri, 1 Mar 2019 12:25:40 +0200 Subject: [PATCH 2/3] Minor improvement in cross-references of the ELisp manual * doc/lispref/modes.texi (Minor Mode Conventions): Add cross-references to related major-mode descriptions. (Bug#34678) --- doc/lispref/modes.texi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/lispref/modes.texi b/doc/lispref/modes.texi index 26cb028d26c..13430243298 100644 --- a/doc/lispref/modes.texi +++ b/doc/lispref/modes.texi @@ -1405,7 +1405,7 @@ The value of this variable is a list of all minor mode commands. @cindex conventions for writing minor modes There are conventions for writing minor modes just as there are for -major modes. These conventions are described below. The easiest way to +major modes (@pxref{Major Modes}). These conventions are described below. The easiest way to follow them is to use the macro @code{define-minor-mode}. @xref{Defining Minor Modes}. @@ -1516,10 +1516,10 @@ or like this, using @code{add-to-list} (@pxref{List Variables}): @end smallexample @end itemize - In addition, several major mode conventions apply to minor modes as -well: those regarding the names of global symbols, the use of a hook at -the end of the initialization function, and the use of keymaps and other -tables. + In addition, several major mode conventions (@pxref{Major Mode +Conventions}) apply to minor modes as well: those regarding the names +of global symbols, the use of a hook at the end of the initialization +function, and the use of keymaps and other tables. The minor mode should, if possible, support enabling and disabling via Custom (@pxref{Customization}). To do this, the mode variable should be From 9df1365f3838704e38f82c138175713a146a7164 Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Fri, 1 Mar 2019 12:30:47 +0200 Subject: [PATCH 3/3] Fix a typo in the Calc manual * doc/misc/calc.texi (Algebraic Tutorial): Fix parentheses in @example. (Bug#34689) --- doc/misc/calc.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/misc/calc.texi b/doc/misc/calc.texi index 0b6e119390e..7cfb7e1f0b2 100644 --- a/doc/misc/calc.texi +++ b/doc/misc/calc.texi @@ -1775,7 +1775,7 @@ evaluated first, then @samp{*}, then @samp{/}, then finally is equivalent to @example -2 + ((3*4*5) / (6*(7^8)) - 9 +2 + ((3*4*5) / (6*(7^8))) - 9 @end example @noindent