From 24c50da3b272f571c320ef800a80c0bc0ce38e28 Mon Sep 17 00:00:00 2001 From: Troy Hinckley Date: Tue, 16 Jul 2019 08:29:09 -0700 Subject: [PATCH 1/2] Auto detect mode suffix in hook keyword --- lisp/use-package/use-package-core.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el index 28bc5a50ed0..a82e7b145c7 100644 --- a/lisp/use-package/use-package-core.el +++ b/lisp/use-package/use-package-core.el @@ -1264,7 +1264,10 @@ meaning: (setq every nil))) every)))) #'use-package-recognize-function - name label arg)))) + (if (string-suffix-p "-mode" (symbol-name name)) + name + (intern (concat (symbol-name name) "-mode"))) + label arg)))) (defalias 'use-package-autoloads/:hook 'use-package-autoloads-mode) From ee292b80bebc2e7a4f3b32bd51363adbb28878d2 Mon Sep 17 00:00:00 2001 From: Troy Hinckley Date: Mon, 17 May 2021 18:33:28 -0600 Subject: [PATCH 2/2] Fix tests and documentation for hook --- test/lisp/use-package/use-package-tests.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/lisp/use-package/use-package-tests.el b/test/lisp/use-package/use-package-tests.el index 3825aa36487..b8063a046f5 100644 --- a/test/lisp/use-package/use-package-tests.el +++ b/test/lisp/use-package/use-package-tests.el @@ -998,15 +998,17 @@ 'foopkg :hook args))) (should-error (norm nil)) (should (equal (norm '(bar)) + '((bar . foopkg-mode)))) + (should (equal (norm '((bar . foopkg))) '((bar . foopkg)))) (should (equal (norm '((bar . baz))) '((bar . baz)))) (should (equal (norm '(((bar baz) . quux))) '(((bar baz) . quux)))) (should (equal (norm '(bar baz)) - '(((bar baz) . foopkg)))) + '(((bar baz) . foopkg-mode)))) (should (equal (norm '((bar baz) (quux bow))) - '(((bar baz) . foopkg) ((quux bow) . foopkg)))) + '(((bar baz) . foopkg-mode) ((quux bow) . foopkg-mode)))) (should (equal (norm '((bar . baz) (quux . bow))) '((bar . baz) (quux . bow)))) (should (equal (norm '(((bar1 bar2) . baz) ((quux1 quux2) . bow))) @@ -1945,9 +1947,9 @@ (use-package nonexistent :hook lisp-mode) `(when (locate-library nonexistent) - (unless (fboundp 'nonexistent) - (autoload #'nonexistent "nonexistent" nil t)) - (add-hook 'lisp-mode-hook #'nonexistent))))) + (unless (fboundp 'nonexistent-mode) + (autoload #'nonexistent-mode "nonexistent" nil t)) + (add-hook 'lisp-mode-hook #'nonexistent-mode))))) (ert-deftest bind-key/:prefix-map () (match-expansion