From 985a674cee9f0c57af3bfe6b2780d0b1fa6348a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Wed, 1 Apr 2026 20:45:21 +0100 Subject: [PATCH] Eglot: revert part of last change * lisp/progmodes/eglot.el (eglot--sig-info): Go back to adding 1, so it's clear that parlabel's are off-by-one. --- lisp/progmodes/eglot.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index a4f076a6197..5ff44e92b79 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -4092,7 +4092,7 @@ for which LSP on-type-formatting should be requested." parameter ;; ...perhaps highlight it in the formals list (when (eq i active-param) - (save-excursion ;; FIXME: Sink into the `if' or hoist out of loop? + (save-excursion (goto-char (point-min)) (pcase-let ((`(,beg ,end) @@ -4100,8 +4100,7 @@ for which LSP on-type-formatting should be requested." (let ((case-fold-search nil)) (and (search-forward parlabel (line-end-position) t) (list (match-beginning 0) (match-end 0)))) - (list (+ (point-min) (aref parlabel 0)) - (+ (point-min) (aref parlabel 1)))))) + (list (1+ (aref parlabel 0)) (1+ (aref parlabel 1)))))) (if (and beg end) (add-face-text-property beg end