From 14c0e69c1d16de638976fc51d6435649bca46c0b Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 2 Jan 2026 22:54:28 +0100 Subject: [PATCH] Review some attribute macro usage * .dir-locals.el (c-noise-macro-names): Remove ANDROID_EXPORT, which is no longer used. Add ATTRIBUTE_COLD, ATTRIBUTE_CONST, ATTRIBUTE_MAY_ALIAS, ATTRIBUTE_NONSTRING, ATTRIBUTE_RETURNS_NONNULL, EXTERNALLY_VISIBLE, MAYBE_UNUSED, and NODISCARD. (c-noise-macro-with-parens-names): Also tell cc-mode about some function-like attribute macros in use (bug#80428). * src/conf_post.h (RE_TRANSLATE_P): Remove; it is no longer used. --- .dir-locals.el | 18 +++++++++++++----- src/conf_post.h | 1 - 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index d9ccf82b166..b1123032443 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -22,11 +22,19 @@ ;; (vc-topic-branch-regexps . ("\\`feature/")) )) (c-mode . ((c-file-style . "GNU") - (c-noise-macro-names . ("INLINE" "NO_INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" - "ATTRIBUTE_NO_SANITIZE_ADDRESS" - "UNINIT" "CALLBACK" "ALIGN_STACK" "ATTRIBUTE_MALLOC" - "ATTRIBUTE_DEALLOC_FREE" "ANDROID_EXPORT" "TEST_STATIC" - "INLINE_HEADER_BEGIN" "INLINE_HEADER_END")) + (c-noise-macro-names + "ALIGN_STACK" "ATTRIBUTE_COLD" "ATTRIBUTE_CONST" + "ATTRIBUTE_DEALLOC_FREE" "ATTRIBUTE_MALLOC" "ATTRIBUTE_MAY_ALIAS" + "ATTRIBUTE_NO_SANITIZE_ADDRESS" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" + "ATTRIBUTE_NONSTRING" "ATTRIBUTE_RETURNS_NONNULL" + "CALLBACK" "EXTERNALLY_VISIBLE" + "INLINE" "INLINE_HEADER_BEGIN" "INLINE_HEADER_END" "NO_INLINE" + "MAYBE_UNUSED" "NODISCARD" "TEST_STATIC" "UNINIT") + (c-noise-macro-with-parens-names + "ARG_NONNULL" "ATTRIBUTE_ALLOC_SIZE" + "ATTRIBUTE_DEALLOC" "ATTRIBUTE_FORMAT_PRINTF" + "ATTRIBUTE_MALLOC_SIZE" "ATTRIBUTE_SECTION" + "EMACS_ATTRIBUTE_NONNULL") (electric-quote-comment . nil) (electric-quote-string . nil) (indent-tabs-mode . t) diff --git a/src/conf_post.h b/src/conf_post.h index 826face9f74..99d3b79e9de 100644 --- a/src/conf_post.h +++ b/src/conf_post.h @@ -179,7 +179,6 @@ extern void _DebPrint (const char *fmt, ...); /* Tell regex.c to use a type compatible with Emacs. */ #define RE_TRANSLATE_TYPE Lisp_Object #define RE_TRANSLATE(TBL, C) char_table_translate (TBL, C) -#define RE_TRANSLATE_P(TBL) (!BASE_EQ (TBL, make_fixnum (0))) #endif /* Tell time_rz.c to use Emacs's getter and setter for TZ.