martin/emacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Replace XSETSYMBOL with make_lisp_symbol"

Browse Source 
This reverts commit de6b1e1efb.

While it did simplify code, there aren't much in the way of technical
benefits the change at this time, and there were protest against the
unwarranted style change.
This commit is contained in:
Mattias Engdegård
2024-03-04 14:14:05 +01:00
parent b9e8474a44
commit 11ffb4656d
5 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/buffer.c
View File

@@ -1340,7 +1340,7 @@ buffer_local_value (Lisp_Object variable, Lisp_Object buffer)
case SYMBOL_LOCALIZED:
{ /* Look in local_var_alist. */
struct Lisp_Buffer_Local_Value *blv = SYMBOL_BLV (sym);
variable = make_lisp_symbol (sym); /* Update In case of aliasing. */
XSETSYMBOL (variable, sym); /* Update In case of aliasing. */
result = assq_no_quit (variable, BVAR (buf, local_var_alist));
if (!NILP (result))
{
@@ -4985,7 +4985,7 @@ defvar_per_buffer (struct Lisp_Buffer_Objfwd *bo_fwd, const char *namestring,
sym->u.s.declared_special = true;
sym->u.s.redirect = SYMBOL_FORWARDED;
SET_SYMBOL_FWD (sym, bo_fwd);
PER_BUFFER_SYMBOL (offset) = make_lisp_symbol (sym);
XSETSYMBOL (PER_BUFFER_SYMBOL (offset), sym);
if (PER_BUFFER_IDX (offset) == 0)
/* Did a DEFVAR_PER_BUFFER without initializing the corresponding