patches: fix all round-1 blockers (B1 B3 B5 B6)
B1 (0007): Fix dangling comment - change context line to deletion so
the opening comment of the removed ns_ax_face_is_selected function
is properly deleted, not left as an unclosed comment fragment that
would cause a compilation failure.
B3 (0002): Fix block_input/record_unwind_protect_void ordering in
two places in accessibilityRangeForPosition: and related method.
Correct order: block_input() BEFORE record_unwind_protect_void(),
so the unwind handler cannot call unblock_input without a matching
block_input even if specpdl_push fails.
B5 (0008): Replace goto skip_overlay_scan with proper if-block.
The goto skipped over ObjC variable declarations which is poor style
and would be flagged by Emacs maintainers. Restructure as
if (MINI_WINDOW_P (w) && !didTextChange) { ... }.
B6 (0008): Fix nlines < 128 to nlines < 512 in ns_ax_selected_child_
frame_text. Arrays line_starts[] and line_ends[] are declared with
size 512; the trailing-line guard used 128, silently dropping the
last line for buffers with 128-511 lines.
This commit is contained in:
@@ -223,10 +223,10 @@ index e4e43dd7a3..c9fe93a57b 100644
|
||||
charposForAccessibilityIndex which handles invisible text. */
|
||||
ptrdiff_t cp_start = charpos_start;
|
||||
ptrdiff_t cp_end = cp_start + charpos_len;
|
||||
@@ -7606,31 +7749,7 @@ already on the main queue (e.g., inside postAccessibilityUpdates
|
||||
@@ -7606,31 +7749,6 @@ already on the main queue (e.g., inside postAccessibilityUpdates
|
||||
freeing the main queue for VoiceOver's dispatch_sync calls. */
|
||||
|
||||
/* Return true if FACE (a symbol or list of symbols) looks like a
|
||||
|
||||
-/* Return true if FACE (a symbol or list of symbols) looks like a
|
||||
- "selected item" face. Substring match is intentionally broad ---
|
||||
- it catches vertico-current, icomplete-selected-match,
|
||||
- ivy-current-match, company-tooltip-selection, and similar.
|
||||
@@ -251,8 +251,7 @@ index e4e43dd7a3..c9fe93a57b 100644
|
||||
- return false;
|
||||
-}
|
||||
-
|
||||
-static inline void
|
||||
+ static inline void
|
||||
static inline void
|
||||
ns_ax_post_notification (id element,
|
||||
NSAccessibilityNotificationName name)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user