martin/emacs-doom
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix VO cursor sync: post FocusedUIElementChanged on self not emacsView

Browse Source 
The notification was posted on self.emacsView (the NSView container).
VoiceOver called accessibilityFocusedUIElement on the view, got back
the same buffer element, and did not re-anchor its browse cursor.

Fix: post on self (the buffer element itself).  When VoiceOver receives
NSAccessibilityFocusedUIElementChangedNotification from an element that
is already focused, it silently re-queries accessibilitySelectedTextRange
and re-anchors its browse cursor without re-announcing the element name.

Covers all emacsMovedCursor granularities (arrow keys, M-f/M-b, C-n/C-p
via the separate isCtrlNP path).
This commit is contained in:
Daneel
2026-03-02 14:40:49 +01:00
parent 8196205c3d
commit 3093053131
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
patches/0008-ns-announce-child-frame-completion-candidates-for-Vo.patch
View File

@@ -518,7 +518,7 @@ index 8d44b5f..29b646d 100644
NSInteger direction = ns_ax_text_selection_direction_discontiguous; NSInteger direction = ns_ax_text_selection_direction_discontiguous;
if (point > oldPoint) if (point > oldPoint)
direction = ns_ax_text_selection_direction_next; direction = ns_ax_text_selection_direction_next;
@@ -9492,6 +9674,36 @@ frameworks like Vertico bump BOTH BUF_MODIFF (via text property @@ -9492,6 +9674,38 @@ frameworks like Vertico bump BOTH BUF_MODIFF (via text property
granularity = ns_ax_text_selection_granularity_line; granularity = ns_ax_text_selection_granularity_line;
} }
@@ -542,14 +542,16 @@ index 8d44b5f..29b646d 100644
+ if (emacsMovedCursor && !isCtrlNP) + if (emacsMovedCursor && !isCtrlNP)
+ direction = ns_ax_text_selection_direction_discontiguous; + direction = ns_ax_text_selection_direction_discontiguous;
+ +
+ /* Post FocusedUIElementChanged on the containing NSView whenever + /* Post FocusedUIElementChangedNotification on the buffer element
+ Emacs moves the cursor independently of VoiceOver. Posting on + itself (not the parent view) so VoiceOver re-queries
+ the view causes VoiceOver to re-query accessibilityFocusedUIElement + accessibilitySelectedTextRange and re-anchors its rotor browse
+ and re-anchor its browse cursor at the new selection range, without + cursor to Emacs' current point. Posting on self (already
+ re-announcing the element name. Required for all granularities. */ + focused) causes VO to silently re-anchor without re-announcing
+ the element name. Required for all granularities (char, word,
+ line). */
+ if (emacsMovedCursor && [self isAccessibilityFocused]) + if (emacsMovedCursor && [self isAccessibilityFocused])
+ ns_ax_post_notification ( + ns_ax_post_notification (
+ self.emacsView, + self,
+ NSAccessibilityFocusedUIElementChangedNotification); + NSAccessibilityFocusedUIElementChangedNotification);
+ +
/* Post notifications for focused and non-focused elements. */ /* Post notifications for focused and non-focused elements. */