patches: review iteration 1 fixes

Shortened ivar comments (line length), broke long ObjC method call,
changed '---' to em-dash in overlay patch comment.
This commit is contained in:
2026-03-01 02:42:49 +01:00
parent 98ca6a378d
commit 132e32795f
8 changed files with 47 additions and 55 deletions

View File

@@ -1,4 +1,4 @@
From c76af5456ed23045749a221bd42896e8f8e8601a Mon Sep 17 00:00:00 2001
From 14ee30459ef494e4c6f0c766cf8d24007e75659a Mon Sep 17 00:00:00 2001
From: Martin Sukany <martin@sukany.cz>
Date: Sat, 28 Feb 2026 16:01:29 +0100
Subject: [PATCH 8/8] ns: announce child frame completion candidates for
@@ -86,7 +86,7 @@ index e76ee93..c3e0b40 100644
for the *Completions* buffer. The implementation uses a virtual
accessibility tree with per-window elements, hybrid SelectedTextChanged
diff --git a/src/nsterm.h b/src/nsterm.h
index 19a7e7a..49e8f00 100644
index 7a8c5a0..9ac65ac 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -596,6 +596,10 @@ typedef NS_ENUM (NSInteger, EmacsAXSpanType)
@@ -109,7 +109,7 @@ index 19a7e7a..49e8f00 100644
@end
diff --git a/src/nsterm.m b/src/nsterm.m
index 72478e0..daa8f61 100644
index a6fce74..75ef0e0 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7028,6 +7028,112 @@ visual line index for Zoom (skip whitespace-only lines
@@ -225,7 +225,7 @@ index 72478e0..daa8f61 100644
/* Build accessibility text for window W, skipping invisible text.
Populates *OUT_START with the buffer start charpos.
Populates *OUT_RUNS with an array of visible runs and *OUT_NRUNS
@@ -12266,6 +12372,77 @@ - (id)accessibilityFocusedUIElement
@@ -12267,6 +12373,77 @@ - (id)accessibilityFocusedUIElement
The existing elements carry cached state (modiff, point) from the
previous redisplay cycle. Rebuilding first would create fresh
elements with current values, making change detection impossible. */
@@ -303,7 +303,7 @@ index 72478e0..daa8f61 100644
- (void)postAccessibilityUpdates
{
NSTRACE ("[EmacsView postAccessibilityUpdates]");
@@ -12276,11 +12453,59 @@ - (void)postAccessibilityUpdates
@@ -12277,11 +12454,59 @@ - (void)postAccessibilityUpdates
/* Re-entrance guard: VoiceOver callbacks during notification posting
can trigger redisplay, which calls ns_update_end, which calls us