patches: review iteration 1 fixes

Shortened ivar comments (line length), broke long ObjC method call,
changed '---' to em-dash in overlay patch comment.
This commit is contained in:
2026-03-01 02:42:49 +01:00
parent 98ca6a378d
commit 132e32795f
8 changed files with 47 additions and 55 deletions

View File

@@ -1,4 +1,4 @@
From f1e29f1ec0695a7c97bfc5587274995a4b1052f1 Mon Sep 17 00:00:00 2001
From af7342d4f5f67531b01f636e00885d40a4edeea5 Mon Sep 17 00:00:00 2001
From: Martin Sukany <martin@sukany.cz>
Date: Sat, 28 Feb 2026 12:58:11 +0100
Subject: [PATCH 5/8] ns: integrate accessibility with EmacsView and redisplay
@@ -52,7 +52,7 @@ index ef36df5..e76ee93 100644
** Re-introduced dictation, lost in Emacs v30 (macOS).
We lost macOS dictation in v30 when migrating to NSTextInputClient.
diff --git a/src/nsterm.h b/src/nsterm.h
index ca67bd9..ec7b587 100644
index 8ea15b1..d308a71 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -593,6 +593,8 @@ typedef NS_ENUM (NSInteger, EmacsAXSpanType)
@@ -65,7 +65,7 @@ index ca67bd9..ec7b587 100644
BOOL font_panel_active;
NSFont *font_panel_result;
diff --git a/src/nsterm.m b/src/nsterm.m
index c852929..f0e8751 100644
index 3a76a0f..156dba9 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -1105,6 +1105,11 @@ static NSRect constrain_frame_rect(NSRect frameRect, bool isFullscreen)
@@ -107,7 +107,7 @@ index c852929..f0e8751 100644
static BOOL
ns_ax_find_completion_overlay_range (struct buffer *b, ptrdiff_t point,
ptrdiff_t *out_start,
@@ -8375,7 +8391,6 @@ - (NSRect)accessibilityFrame
@@ -8376,7 +8392,6 @@ - (NSRect)accessibilityFrame
@end
@@ -115,7 +115,7 @@ index c852929..f0e8751 100644
/* ===================================================================
EmacsAccessibilityBuffer (Notifications) — AX event dispatch
@@ -8920,7 +8935,6 @@ - (NSRect)accessibilityFrame
@@ -8921,7 +8936,6 @@ - (NSRect)accessibilityFrame
@end
@@ -123,7 +123,7 @@ index c852929..f0e8751 100644
/* ===================================================================
EmacsAccessibilityInteractiveSpan — helpers and implementation
=================================================================== */
@@ -9250,6 +9264,7 @@ - (void)dealloc
@@ -9251,6 +9265,7 @@ - (void)dealloc
[layer release];
#endif
@@ -131,7 +131,7 @@ index c852929..f0e8751 100644
[[self menu] release];
[super dealloc];
}
@@ -10598,6 +10613,32 @@ - (void)windowDidBecomeKey /* for direct calls */
@@ -10599,6 +10614,32 @@ - (void)windowDidBecomeKey /* for direct calls */
XSETFRAME (event.frame_or_window, emacsframe);
kbd_buffer_store_event (&event);
ns_send_appdefined (-1); // Kick main loop
@@ -164,7 +164,7 @@ index c852929..f0e8751 100644
}
@@ -11835,6 +11876,332 @@ - (int) fullscreenState
@@ -11836,6 +11877,332 @@ - (int) fullscreenState
return fs_state;
}